feat: add profiling as internal sub-API#8096
Draft
philprime wants to merge 5 commits into
Draft
Conversation
Contributor
|
Add Swift unit, Swift integration, ObjC integration, and ObjC unit tests for SentryInternalProfilingApi. Ports profiling tests from PrivateSentrySDKOnlyTests and adds coverage for the new structured API surface (SentrySDK.internal.profiling / SentryObjCSDK.internal.profiling). Fix existing unit test: profiler can start without SDK (uses kernel APIs directly), so start returns non-zero even before SDK init. ObjC collect tests have a known issue with unrecognized selector for collectBetween:and:for: that needs investigation.
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentryInternalProfilingApias a sub-API onSentryInternalApiwithstart(for:),collect(between:and:for:), anddiscard(for:)methodsPrivateSentrySDKOnlyfor profiling operations (start, collect, discard)SentryObjCInternalProfilingApi) withSentryObjCIdparameters#if !(os(watchOS) || os(tvOS) || os(visionOS))/SENTRY_OBJC_PROFILING_SUPPORTED#skip-changelog