ref: Migrate sample apps to package references#8109
Draft
NinjaLikesCheez wants to merge 17 commits into
Draft
Conversation
… less about linkage
83ef117 to
57ad17c
Compare
Member
Author
|
Added label to trigger the CI, will move out of draft when it's ready for review |
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71e6611 | 1213.27 ms | 1242.25 ms | 28.98 ms |
| 4014441 | 1232.16 ms | 1266.41 ms | 34.25 ms |
| 1c5ecda | 1219.35 ms | 1253.76 ms | 34.41 ms |
| 655e96d | 1217.63 ms | 1258.34 ms | 40.72 ms |
| a48979e | 1244.58 ms | 1269.00 ms | 24.42 ms |
| ba5a1dd | 1234.15 ms | 1257.50 ms | 23.35 ms |
| 8bb6aeb | 1215.82 ms | 1244.84 ms | 29.02 ms |
| da35aa2 | 1224.21 ms | 1249.00 ms | 24.79 ms |
| c3064bc | 1227.20 ms | 1248.25 ms | 21.05 ms |
| 943b250 | 1214.69 ms | 1257.32 ms | 42.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71e6611 | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 4014441 | 24.14 KiB | 1.16 MiB | 1.14 MiB |
| 1c5ecda | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 655e96d | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| a48979e | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| ba5a1dd | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 8bb6aeb | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| da35aa2 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| c3064bc | 24.14 KiB | 1.18 MiB | 1.15 MiB |
| 943b250 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Migrate Sample apps to use package references (instead of project references) so that we can enable traits when testing v10 & any future trait we introduce.
💡 Motivation and Context
Sample apps currently reference the Xcode project rather than the SPM package, which means that we lose SPM traits in the sample apps. This can be worked around by manually setting compiler flags. However, it would be nicer if the sample apps use package references instead and inherit the ability to set traits within the Xcode UI.
💚 How did you test it?
This is a WIP - this section will be updated as time flows inevitably past us all. For now, I'm using 'it builds' as the check to move onto the next sample app and before setting this to 'ready-to-merge' I'll be doing a more thorough testing (including CI)
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.#skip-changelog