Do not capture exception in Rails runner at_exit if the exit code is 0 / success#1988
Merged
st0012 merged 4 commits intogetsentry:masterfrom Feb 3, 2023
Merged
Conversation
Codecov ReportBase: 98.63% // Head: 98.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1988 +/- ##
==========================================
- Coverage 98.63% 98.56% -0.07%
==========================================
Files 157 157
Lines 10009 10035 +26
==========================================
+ Hits 9872 9891 +19
- Misses 137 144 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sl0thentr0py
force-pushed
the
fix-system-exit
branch
from
2ba8071 to
ca39197
Compare
sl0thentr0py
reviewed
Feb 1, 2023
| exit exit_code | ||
| end | ||
|
|
||
| pipe_out.close |
Member
There was a problem hiding this comment.
@st0012 do you have opinions on this test, seems a bit like too much extra work
Contributor
Author
There was a problem hiding this comment.
Note this same test pattern was copied from sentry-raven
sco11morgan
commented
Feb 1, 2023
st0012
approved these changes
Feb 3, 2023
sl0thentr0py
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not capture exception in Rails runner at_exit if the exit code is 0 / success.
Why
Recently a change went in to start capturing a Rails runner exceptions in
at_exit#1820Unfortunately this captures a Sentry alert if a Rails script finishes with
exit 0.Our application has existing scripts that exit with
exit 0and we started seeing Sentry alerts when we upgraded.