chore(devcontainer): use node from features + update images#2827
Merged
chore(devcontainer): use node from features + update images#2827
Conversation
solnic
force-pushed
the
devcontainer-update
branch
from
8b8c9c8 to
0c9231c
Compare
solnic
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN curl -fsSL https://deb.nodesource.com/setup_22.x | bash - |
There was a problem hiding this comment.
Chromium removed from Dockerfile breaks e2e tests
High Severity
The Dockerfile previously installed chromium and chromium-driver via apt-get, which are required by the Selenium-based e2e tests. These packages were removed but not replaced with a devcontainer feature. The test suite in spec/spec_helper.rb explicitly configures Capybara to use selenium_headless_chrome and references /usr/bin/chromium as the browser binary. The e2e tests will fail because Chromium is no longer available in the container.
Collaborator
Author
There was a problem hiding this comment.
No it does not. We install them in the action.
sl0thentr0py
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog