fix: guard empty FalkorDB fulltext queries#1375
Open
FUY25 wants to merge 1 commit intogetzep:mainfrom
Open
Conversation
Member
|
I have read the CLA Document and I hereby sign the CLA YM seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in
FalkorDriver.build_fulltext_query()where a stopword-only query could produce invalid RediSearchsyntax such as
(@group_id:"standups") (). This PR returns an empty string when the filtered query is empty and addsa regression test covering that case.
Type of Change
Objective
This is a bug fix, so no new feature or performance objective applies.
Testing
Locally verified with:
uv run pytest tests/utils/search/test_search_security.py -k stopword_only -vuv run pytest tests/utils/search/test_search_security.py -vuv run ruff check graphiti_core/driver/falkordb_driver.py tests/utils/search/test_search_security.pyBreaking Changes
If this is a breaking change, describe:
Checklist
make lintpasses)Related Issues
Closes #1337