Drop the git config --show-scope option usage#318
Merged
mjcheetham merged 1 commit intogit-ecosystem:masterfrom Mar 24, 2021
Merged
Drop the git config --show-scope option usage#318mjcheetham merged 1 commit intogit-ecosystem:masterfrom
mjcheetham merged 1 commit intogit-ecosystem:masterfrom
Conversation
The Git config `--show-scope` option was only introduced in Git from version 2.26 onwards. The latest version of Git available in some distributions of Linux (or macOS) is often older. We only needed to know the scope of configuration values in one particular call site: reading all Azure Repos user bindinds. Replace the single `IGitConfiguration::Enumerate` call with two calls to `Enumerate`, one for the global scope, and one for the local one. Drop the --show-scope option parsing.
mjcheetham
changed the title
mjcheetham
requested review from
derrickstolee,
dscho and
jeffhostetler
and removed request for
dscho
dscho
approved these changes
Mar 24, 2021
Contributor
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
That's quite elegant! No unnecessary parsing because you simply use the scope that you wanted to have in the first place. I like it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Git config
--show-scopeoption was only introduced in Git fromversion 2.26 onwards. The latest version of Git available in some
distributions of Linux (or macOS) is often older.
We only needed to know the scope of configuration values in one
particular call site: reading all Azure Repos user bindinds.
Replace the single
IGitConfiguration::Enumeratecall with two calls toEnumerate, one for the global scope, and one for the local one.Drop the --show-scope option parsing.
Fixes: #313