Agent tag not reset when no more set

[g-bougard]

Code of Conduct

• I agree to follow this project's Code of Conduct

Disable plugins

• I reproduce the issue with all plugins disabled

Is there an existing issue for this?

• I have searched the existing issues

Version

11.0.6

Bug description

After a submitted inventory with tag set has been submitted, the tag is kept if tag is removed from the following inventory.

Relevant log output

Page URL

No response

Steps To reproduce

1. Import an inventory with tag set: tag-issue-with-tag.json
2. Check the asset in glpi and see it has a tag
3. Import an inventory from the same asset and with the same deviceid but this time with no tag: tag-issue-no-tag.json
4. Check the asset in glpi and see the previous tag has been kept

This is also the case with xml inventory: tag-issue-with-tag.xml vs tag-issue-no-tag.xml

Your GLPI setup information

No response

Anything else?

This only happens when deviceid remains the same. The use case is when you reconfigure an agent on a computer to remove the previously tag and after it submitted at least one inventory.

[g-bougard]

Provided inventories has been forged to reproduce the case but I also tested with real inventory.

[trasher]

So, network (inventories|discoveries) can add a TAG, it's stored with the agent. But that's not correct, since the agent is linked on the Computer if it's part of the inventory, I'm not sure its tag should be changed.

I'm not sure how TAG from a net(inv|disco) should be handled. Any idea how that was supposed to work when it's been implemented?
I guess it should not be stored in the agent configuration; but maybe it should be kept to be used in rules, or similar.

@stonebuzz @g-bougard