fix compress middleware: exact match and respect q=0 in Accept-Encoding#1074
Open
Emil-Ka wants to merge 1 commit intogo-chi:masterfrom
Open
fix compress middleware: exact match and respect q=0 in Accept-Encoding#1074Emil-Ka wants to merge 1 commit intogo-chi:masterfrom
Emil-Ka wants to merge 1 commit intogo-chi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1069
matchAcceptEncodingusedstrings.Containswhich caused two bugs:Accept-Encoding: brincorrectly matched encodingb,bgzipmatchedgzipq=0means the encoding is explicitly not acceptable, butstrings.Contains("gzip;q=0", "gzip")returned trueFix: parse the encoding token properly — split on
;, trim whitespace, exact-match the name, reject whenq=0.Added unit tests covering all edge cases.