Implemented pooled LOD updating via LODManager.#4
Open
SIsilicon wants to merge 5 commits intogodot-extended-libraries:masterfrom
Open
Implemented pooled LOD updating via LODManager.#4SIsilicon wants to merge 5 commits intogodot-extended-libraries:masterfrom
SIsilicon wants to merge 5 commits intogodot-extended-libraries:masterfrom
Conversation
Improved Node UI.
Author
|
Hang on a moment. I just discovered a problem with the Singleton loading. This won't take long. |
The singleton had to be loaded on runtime rather than with its own name.
Author
|
There! |
Calinou
reviewed
Oct 13, 2020
Updated Changelog.
Also fixed an error that occurs when there are no LODs to process.
Author
|
Second time I was fixing the Singleton! It should be good this time. |
Member
|
@SIsilicon Thanks! I don't have time to test this PR right now, so I can't merge this right away, unfortunately. |
Author
|
That's ok, take your time! |
|
Is there any update on this? |
Member
I would appreciate if someone could test it in a real-world project (make backups first), just to see if it actually works as expected. Then I could merge this and tag a 2.0.0 release (as it'll break compatibility). You can test it by cloning SIsilicon's fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remember that suggestion @lawnjelly made about the way LODs are updated? Well this pull request has this feature implemented.
the refresh project settings have been replaced with
refresh_threshold_ms. The lower this value is, the less time the plugin has to update LODs in the scene, and thus the less that can be updated in one frame. LODs that aren't processed in a certain frame will have to wait till the next one. This proves to be very flexible as no matter how many LODs are in a scene. Only so much can be updated within the allocated time, improving performance and scalability.The Node inspector UIs were also given a makeover.
Maintainer edit: This closes #3.