fix: replace unsafe Message.Bytes cast with exhaustive when expression#102
Open
dhiraj-143r wants to merge 1 commit intogojek:mainfrom
Open
fix: replace unsafe Message.Bytes cast with exhaustive when expression#102dhiraj-143r wants to merge 1 commit intogojek:mainfrom
dhiraj-143r wants to merge 1 commit intogojek:mainfrom
Conversation
Replace the hard cast '(message as Message.Bytes).value' with a new toByteArray() method on the Message sealed class that uses an exhaustive when expression. This prevents ClassCastException if new Message subtypes are added in the future. Fixes gojek#101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
The send() method in MqttCourierClient does a hard cast (message as Message.Bytes).value which is unsafe since Message is a sealed class meant for extension. A custom MessageAdapter could return a different subtype, causing a ClassCastException.
Added a toByteArray() method to the Message sealed class using an exhaustive when, and replaced the hard cast with it. This is the same pattern already used in GsonMessageAdapter.fromMessage().