Skip to content

updated hystrix-go#134

Open
raghavTayal wants to merge 2 commits intogojek:masterfrom
raghavTayal:rolling_window_configuration
Open

updated hystrix-go#134
raghavTayal wants to merge 2 commits intogojek:masterfrom
raghavTayal:rolling_window_configuration

Conversation

@raghavTayal
Copy link
Copy Markdown

No description provided.

"github.com/gojek/heimdall/v7"
"github.com/gojek/heimdall/v7/httpclient"
"github.com/pkg/errors"
"github.com/raghavTayal/hystrix-go/hystrix"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change module path to your personal repo? seems suspicious

@@ -1,14 +1,13 @@
module github.com/gojek/heimdall/v7
module github.com/raghavTayal/heimdall/v7
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not change module path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants