cmd/go/internal/modfetch/codehost: set LC_ALL=C for VCS commands#78024
cmd/go/internal/modfetch/codehost: set LC_ALL=C for VCS commands#78024JackDanger wants to merge 1 commit intogolang:masterfrom
Conversation
When the go command shells out to version control tools (git, hg, svn, fossil, bzr), the error messages come back in whatever locale the user has configured. This makes error message parsing unreliable for users with non-English locales. Set LC_ALL=C in the environment for all VCS subprocess invocations so that error output is always in English and can be parsed consistently.
|
This PR (HEAD: fa375bf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/752960. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/752960. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/752960. |
When the go command shells out to version control tools (git, hg, svn,
fossil, bzr), the error messages come back in whatever locale the user
has configured. This makes error message parsing unreliable for users
with non-English locales.
Set LC_ALL=C in the environment for all VCS subprocess invocations so
that error output is always in English and can be parsed consistently.
This resolves the TODO comment that was in the code requesting exactly
this change.