Skip to content

os: update examples to use errors.Is instead of deprecated helpers#78514

Open
kovan wants to merge 1 commit intogolang:masterfrom
kovan:doc-os-errors-is
Open

os: update examples to use errors.Is instead of deprecated helpers#78514
kovan wants to merge 1 commit intogolang:masterfrom
kovan:doc-os-errors-is

Conversation

@kovan
Copy link
Copy Markdown
Contributor

@kovan kovan commented Apr 2, 2026

The os.IsExist and os.IsNotExist functions predate errors.Is
and their documentation recommends using
errors.Is(err, fs.ErrExist) and errors.Is(err, fs.ErrNotExist)
in new code.

Update ExampleMkdir and ExampleUserConfigDir to follow this
recommendation.

Fixes #77643

The os.IsExist and os.IsNotExist functions predate errors.Is and
their documentation recommends using errors.Is(err, fs.ErrExist)
and errors.Is(err, fs.ErrNotExist) in new code.

Update ExampleMkdir and ExampleUserConfigDir to follow this
recommendation.

Change-Id: I791a9dcac624abdcd35cbeba11640fc895f2706f
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 7a2e0b5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762400.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Sean Liao:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/762400.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-03T01:06:18Z","revision":"8b4ff570cddfcf2dc9269fab4c043137865882f7"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/762400.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Sean Liao:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_34788>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/762400.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386_debiansid has failed with summary (view all results):


To reproduce, try gomote repro 8685584265789393825.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/762400.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/762400.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

os: some examples use functions obviated by errors.Is

2 participants