feat: add tqdm progress bars to TimesFMFinetuner#377
Open
yasumorishima wants to merge 3 commits intogoogle-research:masterfrom
Open
feat: add tqdm progress bars to TimesFMFinetuner#377yasumorishima wants to merge 3 commits intogoogle-research:masterfrom
yasumorishima wants to merge 3 commits intogoogle-research:masterfrom
Conversation
- Add progress_bar flag to FinetuningConfig (default: True) - Wrap train and validation DataLoader loops with tqdm - Show running loss in training progress bar via set_postfix - Only display on rank 0 in distributed training - Can be disabled with config.progress_bar = False Fixes google-research#289
- Add progress_bar field to FinetuningConfig docstring - Update set_postfix to use log_every_n_steps interval with running avg loss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional tqdm progress bars to
TimesFMFinetunertraining and validation loops.progress_bar: bool = Trueflag toFinetuningConfig_train_epochand_validateDataLoader loops with tqdm (rank 0 only)set_postfixduring trainingTrue, can be disabled withconfig.progress_bar = FalseFixes #289
Changes
v1/src/finetuning/finetuning_torch.py