Fix #382: Remove torch_compile=True from basic example#386
Open
Jah-yee wants to merge 2 commits intogoogle-research:masterfrom
Open
Fix #382: Remove torch_compile=True from basic example#386Jah-yee wants to merge 2 commits intogoogle-research:masterfrom
Jah-yee wants to merge 2 commits intogoogle-research:masterfrom
Conversation
added 2 commits
April 3, 2026 20:06
This line is not required for basic usage and can cause confusion when users don't have compatible GPUs (e.g., Apple Silicon M-series). Fixes issue google-research#382
This reverts commit 6b57cfc.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #382 - the torch_compile=True parameter is not covered in the README and causes confusion for users without compatible GPUs.
The basic code example should work without torch_compile for most users. torch_compile is an optimization that's not needed for basic usage.