Implement string literal trim() folding#2900
Closed
puddly wants to merge 2 commits intogoogle:masterfrom
puddly:peephole-string-trim
Closed
Implement string literal trim() folding#2900puddly wants to merge 2 commits intogoogle:masterfrom puddly:peephole-string-trim
puddly wants to merge 2 commits intogoogle:masterfrom
puddly:peephole-string-trim
Conversation
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Contributor
|
I think this PR looks OK to accept, but we do need the CLA signature to do so. |
Contributor
Author
|
Alright, I've signed it. |
Collaborator
|
CLAs look good, thanks! |
Contributor
|
imported and sent for internal testing and review |
Contributor
|
submitted internally. |
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this pull request
Jul 16, 2018
Closes google#2900 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=194607689
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ECMAScript spec requires implementations at least trim off Unicode 3.0 whitespace characters plus the BOM. I've included all of code points with the
White_Spaceproperty from Unicode 10.0.0.