Merged
Conversation
Contributor
There was a problem hiding this comment.
Actually if you have five keys or less you can just use .of() instead of the builder: http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/ImmutableMap.html#of(K, V)
so in this case:
ImmutableMap.of(
"QUIET", WarningLevel.QUIET,
"DEFAULT", WarningLevel.DEFAULT,
"VERBOSE", WarningLevel.VERBOSE);
Contributor
|
With this new version, I have no objections. |
Contributor
|
I'm fine with this. |
MatrixFrog
added a commit
that referenced
this pull request
May 7, 2014
simplify the command-line api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I remembered why I wanted this! It makes things a lot easier to read and to type. xargs + find isn't a good solution, because it's non-portable (find works slightly differently on different unixes)
There are 3 major changes here:
Based on feedback from the last PR, I added better docs on how to use this, and got rid of the gcc-style O=2