Fix CallbackService forward declaration scope with --grpc-callback-api#9139
Open
KirtiRamchandani wants to merge 1 commit into
Open
Fix CallbackService forward declaration scope with --grpc-callback-api#9139KirtiRamchandani wants to merge 1 commit into
KirtiRamchandani wants to merge 1 commit into
Conversation
Move the CallbackService forward declaration out of StubInterface so it is declared in the enclosing service class scope. The out-of-class CallbackService definition expects MonsterStorage::CallbackService, not MonsterStorage::StubInterface::CallbackService. Fixes google#9130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--grpc-callback-apiis used,flatcemitted theCallbackServiceforward declaration insideStubInterfaceinstead of in the enclosing service class. The out-of-classCallbackServicedefinition usesService::CallbackService, so the forward declaration must be at the service scope.Fix
Move the
class CallbackService;forward declaration to after theStubInterfaceclosing brace, so it is declared asMonsterStorage::CallbackServicerather thanMonsterStorage::StubInterface::CallbackService.Testing
flatcand regeneratedtests/monster_test.grpc.fb.hgolden filegrpc/tests/grpctest_callback_compile.cppvalidatesMonsterStorage::CallbackServiceusage (requires gRPC to run locally)Fixes #9130