Skip to content

Reem Kufi Fun: Version 1.005 added#5384

Merged
RosaWagner merged 1 commit intomainfrom
gftools_packager_ofl_reemkufifun
Oct 13, 2022
Merged

Reem Kufi Fun: Version 1.005 added#5384
RosaWagner merged 1 commit intomainfrom
gftools_packager_ofl_reemkufifun

Conversation

@yanone
Copy link
Copy Markdown
Contributor

@yanone yanone commented Oct 10, 2022

9239ee3: [gftools-packager] Reem Kufi Fun: Version 1.005 added

@yanone yanone linked an issue Oct 10, 2022 that may be closed by this pull request
@yanone yanone linked an issue Oct 10, 2022 that may be closed by this pull request
@yanone yanone added -- Bad rendering Hinting issue mostly, or inconsistencies among servers - Ready for Review I Font Bug II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts labels Oct 10, 2022
@gf-bot
Copy link
Copy Markdown

gf-bot commented Oct 10, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[18] ReemKufiFun[wght].ttf
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at ofl/reemkufifun failed to parse.
    TRACEBACK:
    29:1 : Message type "google.fonts_public.FamilyProto" has no field named "primary_script". [code: parsing-error]
🔥 FAIL: Check font names are correct (com.google.fonts/check/font_names)
  • 🔥 FAIL Font names are incorrect:
nameID current expected
Family Name Reem Kufi Fun Reem Kufi Fun
Subfamily Name Regular Regular
Full Name Reem Kufi Fun Reem Kufi Fun Regular
Poscript Name ReemKufiFun ReemKufiFun-Regular
  • WARN Regular missing from full name [code: lacks-regular]
🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
  • 🔥 FAIL The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script. [code: lacks-smart-dropout]
🔥 FAIL: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
  • 🔥 FAIL The following glyph names do not comply with naming conventions: hamza-ar, highhamza-ar, alef-ar, alef-ar.1, alef-ar.2, alef-ar.3, alef-ar.fina, alef-ar.fina.Lam, alef-ar.fina.Lam.1, behDotless-ar and 219 more.

Use -F or --full-lists to disable shortening of long lists.

A glyph name must be entirely comprised of characters from the following set: A-Z a-z 0-9 .(period) (underscore). A glyph name must not start with a digit or period. There are a few exceptions such as the special glyph ".notdef". The glyph names "twocents", "a1", and "" are all valid, while "2cents" and ".twocents" are not. [code: found-invalid-names]

🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Regular' instance has the same coordinates as the default instance; its postscript name should be 'ReemKufiFun', instead of 'ReemKufiFun-Regular'. [code: invalid-default-instance-postscript-nameid:261]
WARN: Description strings in the name table must not exceed 200 characters. (com.google.fonts/check/name/description_max_length)
  • WARN A few name table entries with ID=10 (NameID.DESCRIPTION) are longer than 200 characters. Please check whether those entries are copyright notices mistakenly stored in the description string entries by a bug in an old FontLab version. If that's the case, then such copyright notices must be removed from these entries. [code: too-long]
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • IJacute

    • ijacute

    • macronbelowcomba

    • threedotsdownabove-ar

    • And threedotsupbelow-ar
      [code: unreachable-glyphs]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/reemkufifun/ReemKufiFun[wght].ttf
Dehinted Size 139.4kb
Hinted Size 139.4kb
Increase 0 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.005'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.005"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/reemkufifun [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 5 5 91 9 117 0
0% 2% 2% 40% 4% 52% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner added III Improve rendering / layout by addition of manual hinting, kerning or else II Color font and removed -- Bad rendering Hinting issue mostly, or inconsistencies among servers labels Oct 12, 2022
@RosaWagner
Copy link
Copy Markdown
Contributor

Since Rod reported a missing SVG table in Foldit, I checked this one for it manually, and there is none.

@m4rc1e
Copy link
Copy Markdown
Collaborator

m4rc1e commented Oct 12, 2022

The FB check which tests this still needs merging fonttools/fontbakery#3889

@RosaWagner RosaWagner added -- Needs Upstream Resolution Upstream fix required before moving forward and removed - Ready for Review labels Oct 13, 2022
@yanone
Copy link
Copy Markdown
Contributor Author

yanone commented Oct 13, 2022

I'll let Khaled know so he can integrate maximum_color it into his repo

@yanone
Copy link
Copy Markdown
Contributor Author

yanone commented Oct 13, 2022

Khaled says the expected "Regular" in the name checks are nonsense, as this is a Regular font. Will this be able to pass?

@m4rc1e
Copy link
Copy Markdown
Collaborator

m4rc1e commented Oct 13, 2022

It's fine since previous version was like this. I'm going to just raise a WARN if Regular fonts are missing Regular of the fullname and ps name in the future.

@yanone
Copy link
Copy Markdown
Contributor Author

yanone commented Oct 13, 2022

Another quite important question: Khaled just verified why I ask a SVG table of him given that this is a COLRv0 font. I think he's right. The fontbakery check is explicit about that and actually complains when a COLRv0 font has a SVG table, while it demands one for a COLRv1 font.

@m4rc1e
Copy link
Copy Markdown
Collaborator

m4rc1e commented Oct 13, 2022

Correct, COLR v0 doesn't need it. However, the FB check for this has only just been merged fonttools/fontbakery#3889 so we'll only be able to test this correctly once the next release is out.

@yanone
Copy link
Copy Markdown
Contributor Author

yanone commented Oct 13, 2022

So then this one is good to go

@RosaWagner RosaWagner added - Ready for Review and removed -- Needs Upstream Resolution Upstream fix required before moving forward labels Oct 13, 2022
@RosaWagner RosaWagner merged commit 4cff558 into main Oct 13, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_reemkufifun branch October 13, 2022 14:06
@RosaWagner RosaWagner added --- to production and removed --- to sandbox II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts labels Oct 26, 2022
@RosaWagner RosaWagner added --- Live Font is visible on API and removed --- to production labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

--- Live Font is visible on API I Small Fix bugs fixed but nothing added II Color font III Improve rendering / layout by addition of manual hinting, kerning or else

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Reem Kufi Fun (Windows 10 rendering bug)

4 participants