Add doc URL to profile format and use it display help link.#888
Add doc URL to profile format and use it display help link.#888aalexand merged 3 commits intogoogle:mainfrom
Conversation
ghemawat
commented
Aug 27, 2024

Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 66.86% 67.33% +0.47%
==========================================
Files 44 44
Lines 9824 9822 -2
==========================================
+ Hits 6569 6614 +45
+ Misses 2794 2761 -33
+ Partials 461 447 -14 ☔ View full report in Codecov by Sentry. |
|
This is now ready to review. Changes from prior commit:
|
|
Will need another approval because of the comment change, sorry. |
|
@ghemawat We didn't add printing the link in the pprof CLI output, right? Should we add that too? E.g. the |
Good point. I can do that in a bit. It is less useful since it doesn't show up as a clickable link, but might as well add it. |
github.com/google/pprof/pull/888 added this field in pprof proto, this change adds it to the OTel profiling proto to match the change.