Safari support

[tali]

Safari (version 16) does not support TrustedTypes and safevalues thus falls back to its own implementation (HtmlImpl).
But HtmlImpl is only working in nodejs environments as it checks for an environment variable via process.env (see html_impl.ts:20)
When using safevalues in Safari, this only leads to the error message 'ReferenceError: Can't find variable: process'.

[neuracr]

Thanks for reporting.
Do you have a link to a reproducer?

The intended behavior depends on the webpack mode (https://webpack.js.org/guides/production/#specify-the-mode):

• In 'production' mode, the html_impl.ts:20 block should be optimized away, as well as the dev.ts
• In anything else than 'production', dev.ts sets the process variable when it's not running in Node. The block in html_impl.ts:20 is not optimized away.

I've found https://github.com/pahund/webpack-devprod-experiment which does a similar thing.

[tali]

I found this problem in Gerrit master, which now uses safevalues.
Gerrit uses rollup instead of webpack, but when I use rollup-plugin-define for process.env.NODE_ENV then it works as intended again.
Thanks for the help!

[tali]

Gerrit bug https://bugs.chromium.org/p/gerrit/issues/detail?id=16296 is closed.