Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Use actual server port in redirect_uri to allow automatic assignment#33

Merged
busunkim96 merged 2 commits intogoogleapis:masterfrom
sqrrrl:master
May 9, 2019
Merged

Use actual server port in redirect_uri to allow automatic assignment#33
busunkim96 merged 2 commits intogoogleapis:masterfrom
sqrrrl:master

Conversation

@sqrrrl
Copy link
Copy Markdown
Contributor

@sqrrrl sqrrrl commented Mar 7, 2019

Allows port 0 for localhost flows, which assigns an random unused ephemeral port. Intended as proper fix for googleworkspace/python-samples#89

@sqrrrl
Copy link
Copy Markdown
Contributor Author

sqrrrl commented Mar 7, 2019

I didn't go so far as to make it the default, but ideally it should be. For the local server flows we shouldn't be hard coding a specific port.

@sqrrrl
Copy link
Copy Markdown
Contributor Author

sqrrrl commented Mar 7, 2019

The remaining lint errors appear to be pre-existing issues.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 14, 2019
@sqrrrl
Copy link
Copy Markdown
Contributor Author

sqrrrl commented May 8, 2019

ping

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@busunkim96 busunkim96 merged commit c547be6 into googleapis:master May 9, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants