feat(bigquery): add tracing telemetry to Table and Routine operations#14216
Merged
westarle merged 2 commits intogoogleapis:mainfrom Mar 25, 2026
Merged
feat(bigquery): add tracing telemetry to Table and Routine operations#14216westarle merged 2 commits intogoogleapis:mainfrom
westarle merged 2 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces tracing telemetry for BigQuery Table and Routine operations. This is achieved by adding new helper functions in bigquery/trace.go to construct resource names and set trace metadata. These helpers are then called from the respective methods in bigquery/table.go and bigquery/routine.go. The changes are accompanied by new test cases in bigquery/trace_test.go that verify the new telemetry attributes, and an existing test was refactored to improve attribute validation logic. A suggestion has been made to use github.com/google/go-cmp/cmp for clearer attribute validation in tests.
6defca9 to
a3041bb
Compare
83c733e to
5bb8801
Compare
5bb8801 to
80cbbdc
Compare
hongalex
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.