Skip to content

feat(bigquery): add tracing telemetry to Table and Routine operations#14216

Merged
westarle merged 2 commits intogoogleapis:mainfrom
westarle:bigquery-trace-p2-tables
Mar 25, 2026
Merged

feat(bigquery): add tracing telemetry to Table and Routine operations#14216
westarle merged 2 commits intogoogleapis:mainfrom
westarle:bigquery-trace-p2-tables

Conversation

@westarle
Copy link
Copy Markdown
Contributor

No description provided.

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Mar 19, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tracing telemetry for BigQuery Table and Routine operations. This is achieved by adding new helper functions in bigquery/trace.go to construct resource names and set trace metadata. These helpers are then called from the respective methods in bigquery/table.go and bigquery/routine.go. The changes are accompanied by new test cases in bigquery/trace_test.go that verify the new telemetry attributes, and an existing test was refactored to improve attribute validation logic. A suggestion has been made to use github.com/google/go-cmp/cmp for clearer attribute validation in tests.

Comment thread bigquery/trace_test.go
@westarle westarle force-pushed the bigquery-trace-p2-tables branch from 6defca9 to a3041bb Compare March 19, 2026 23:16
@westarle westarle marked this pull request as ready for review March 19, 2026 23:35
@westarle westarle requested review from a team as code owners March 19, 2026 23:35
@westarle westarle force-pushed the bigquery-trace-p2-tables branch 2 times, most recently from 83c733e to 5bb8801 Compare March 23, 2026 02:05
@westarle westarle force-pushed the bigquery-trace-p2-tables branch from 5bb8801 to 80cbbdc Compare March 24, 2026 18:06
@westarle westarle merged commit 8d67792 into googleapis:main Mar 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants