feat(spanner): add EnableDirectAccess field to ClientConfig#14287
Merged
sakthivelmanii merged 3 commits intomainfrom Mar 30, 2026
Merged
feat(spanner): add EnableDirectAccess field to ClientConfig#14287sakthivelmanii merged 3 commits intomainfrom
sakthivelmanii merged 3 commits intomainfrom
Conversation
This change introduces the EnableDirectAccess boolean to ClientConfig, allowing users to explicitly configure whether the Spanner client connects to the directpath XDS endpoint. The environment variable GOOGLE_SPANNER_ENABLE_DIRECT_ACCESS continues to remain fully supported, and takes precedence over the programmatic client configuration for flexible overriding.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an EnableDirectAccess field to the ClientConfig struct, providing a programmatic way to enable DirectPath in the Spanner client. The internal logic was updated to ensure that the GOOGLE_SPANNER_ENABLE_DIRECT_ACCESS environment variable takes precedence over this new configuration field. Feedback was provided to improve the documentation of the new field by explicitly mentioning this precedence to avoid potential user confusion.
Comment on lines
+377
to
+379
| // EnableDirectAccess option is used to enable the directpath. | ||
| // | ||
| // Default: false |
Contributor
There was a problem hiding this comment.
To improve clarity for users, it would be helpful to mention in this comment that the GOOGLE_SPANNER_ENABLE_DIRECT_ACCESS environment variable takes precedence over this programmatic setting. This will prevent confusion about which configuration is applied.
// EnableDirectAccess option is used to enable the directpath.
// This setting is overridden by the GOOGLE_SPANNER_ENABLE_DIRECT_ACCESS
// environment variable if it is set.
//
// Default: false
rahul2393
approved these changes
Mar 30, 2026
rahul2393
approved these changes
Mar 30, 2026
rahul2393
added a commit
that referenced
this pull request
Apr 14, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.10.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b04b076f5eedbb5546bd6fc1404969dd3698c8b19c0f34ae815a84ae735a606a <details><summary>spanner: v1.90.0</summary> ## [v1.90.0](spanner/v1.89.0...spanner/v1.90.0) (2026-04-14) ### Features * feat(spanner): add EnableDirectAccess field to ClientConfig (#14287) ([6adf5b7](6adf5b7)) * feat(spanner): Switch to using builtin open telemetry for EEF (#14193)([751febd](751febd)) * feat(spanner): complete location-aware routing resilience and observability (#14418 ) ([77aa4df](77aa4df)) ### Bug Fixes * fix(spanner): set gauge metric start time to match end time (#14289) ([e0760b5](e0760b5)) * fix(spanner): update DirectPath detection logic to use ALTS credentials(#14288)([3cd5716](3cd5716)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces the
EnableDirectAccessboolean toClientConfig, allowing users to explicitly configure whether the Spanner client connects to the directpath XDS endpoint.The environment variable
GOOGLE_SPANNER_ENABLE_DIRECT_ACCESScontinues to remain fully supported, and takes precedence over the programmatic client configuration for flexible overriding.