chore: update librariangen image SHA#14315
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the librarian image, adjusts license header formatting in Bigtable, and initializes the BigLake library version to 0.0.0. It also bumps the Bigtable version to 1.45.0. Feedback indicates that the Bigtable version bump is not reflected in the internal version file, and it is suggested to use a standard initial version for BigLake instead of 0.0.0.
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // https://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Are the other libraries already using https? It's odd to see only a single internal/version.go being changed here.
There was a problem hiding this comment.
I overlooked the space in two templates (one from librarian and one from librariangen).
The difference is caused by a manual release of bigtable.
The new image will use the same template.
| - path: google/cloud/beyondcorp/clientconnectorservices/v1 | ||
| - path: google/cloud/beyondcorp/clientgateways/v1 | ||
| - name: biglake | ||
| version: 0.0.0 |
There was a problem hiding this comment.
Is anything going to expect this version to exist as a tag? I note that biglake isn't in .librarian/state.yaml at all yet - is that deliberate? (And if it's going to be added, will that have version 0.0.0 or not? Because if it has something else, that would potentially end up being synchronized back to librarian.yaml...)
There was a problem hiding this comment.
Is anything going to expect this version to exist as a tag?
I tested the version, 0.0.0, using legacylibrarian. legacylibrarian doesn't expect this tag.
I note that biglake isn't in .librarian/state.yaml at all yet - is that deliberate?
biglake is already in state.yaml, the version is 0.0.0.
The reason I added this version is b/c librarian add didn't assign an initial version. It did cause a problem in legacylibrarian release stage so I had to manually add a version in state.yaml.
Later, I fixed the problem in librarian (googleapis/librarian#4951) and sync the version from state.yaml.
There was a problem hiding this comment.
Apologies, I thought I'd looked at all of state.yaml, but I hadn't.
I've found the code in legacylibrarian now: https://github.com/googleapis/librarian/blob/main/internal/legacylibrarian/legacylibrarian/release_stage.go#L215C2-L215C32
All good.
| path: google/cloud/bigquery/v2 | ||
| - name: bigtable | ||
| version: 1.44.0 | ||
| version: 1.45.0 |
There was a problem hiding this comment.
Why is this PR bumping the version of bigtable? (I think some more context on the PR might be useful.)
There was a problem hiding this comment.
Go team manually release bigtable thus has this version update.
I used syncversion tool to update the version.
Moving forward, I've updated legacylibrarian release stage to update the version from state.yaml to librarian.yaml.
|
I now understand and agree with the bigtable changes. The use of 0.0.0 when that doesn't exist as a tag is still potentially worrying. |
0.0.0 is used as a sign of not finding tags in the language repo: https://github.com/googleapis/librarian/blob/1144f1c1baf392135d8c621caaecb7c3f4826ba9/internal/legacylibrarian/legacylibrarian/release_stage.go#L215 |
| - path: google/cloud/beyondcorp/clientconnectorservices/v1 | ||
| - path: google/cloud/beyondcorp/clientgateways/v1 | ||
| - name: biglake | ||
| version: 0.0.0 |
There was a problem hiding this comment.
Apologies, I thought I'd looked at all of state.yaml, but I hadn't.
I've found the code in legacylibrarian now: https://github.com/googleapis/librarian/blob/main/internal/legacylibrarian/legacylibrarian/release_stage.go#L215C2-L215C32
All good.
Update legacylibrarian Go image SHA, this image contains latest template of version.go.
Regenerate all libraries with: