Skip to content

chore: update librariangen image SHA#14315

Merged
JoeWang1127 merged 2 commits intogoogleapis:mainfrom
JoeWang1127:chore/update-image-2
Apr 1, 2026
Merged

chore: update librariangen image SHA#14315
JoeWang1127 merged 2 commits intogoogleapis:mainfrom
JoeWang1127:chore/update-image-2

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

Update legacylibrarian Go image SHA, this image contains latest template of version.go.

Regenerate all libraries with:

# Sync library versions
go run github.com/googleapis/librarian/tool/cmd/syncversion@${V} .
# Regenerate
go run github.com/googleapis/librarian/cmd/librarian@${V} generate --all

@JoeWang1127 JoeWang1127 requested review from a team as code owners March 31, 2026 22:24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the librarian image, adjusts license header formatting in Bigtable, and initializes the BigLake library version to 0.0.0. It also bumps the Bigtable version to 1.45.0. Feedback indicates that the Bigtable version bump is not reflected in the internal version file, and it is suggested to use a standard initial version for BigLake instead of 0.0.0.

Comment thread librarian.yaml
Comment thread librarian.yaml
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) March 31, 2026 22:29
@JoeWang1127 JoeWang1127 requested a review from codyoss March 31, 2026 22:39
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
// https://www.apache.org/licenses/LICENSE-2.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the other libraries already using https? It's odd to see only a single internal/version.go being changed here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked the space in two templates (one from librarian and one from librariangen).

The difference is caused by a manual release of bigtable.

The new image will use the same template.

Comment thread librarian.yaml
- path: google/cloud/beyondcorp/clientconnectorservices/v1
- path: google/cloud/beyondcorp/clientgateways/v1
- name: biglake
version: 0.0.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anything going to expect this version to exist as a tag? I note that biglake isn't in .librarian/state.yaml at all yet - is that deliberate? (And if it's going to be added, will that have version 0.0.0 or not? Because if it has something else, that would potentially end up being synchronized back to librarian.yaml...)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anything going to expect this version to exist as a tag?

I tested the version, 0.0.0, using legacylibrarian. legacylibrarian doesn't expect this tag.

I note that biglake isn't in .librarian/state.yaml at all yet - is that deliberate?

biglake is already in state.yaml, the version is 0.0.0.

The reason I added this version is b/c librarian add didn't assign an initial version. It did cause a problem in legacylibrarian release stage so I had to manually add a version in state.yaml.

Later, I fixed the problem in librarian (googleapis/librarian#4951) and sync the version from state.yaml.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I thought I'd looked at all of state.yaml, but I hadn't.

I've found the code in legacylibrarian now: https://github.com/googleapis/librarian/blob/main/internal/legacylibrarian/legacylibrarian/release_stage.go#L215C2-L215C32

All good.

Comment thread librarian.yaml
path: google/cloud/bigquery/v2
- name: bigtable
version: 1.44.0
version: 1.45.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR bumping the version of bigtable? (I think some more context on the PR might be useful.)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go team manually release bigtable thus has this version update.

I used syncversion tool to update the version.

Moving forward, I've updated legacylibrarian release stage to update the version from state.yaml to librarian.yaml.

@jskeet
Copy link
Copy Markdown
Contributor

jskeet commented Apr 1, 2026

I now understand and agree with the bigtable changes. The use of 0.0.0 when that doesn't exist as a tag is still potentially worrying.

@JoeWang1127
Copy link
Copy Markdown
Contributor Author

I now understand and agree with the bigtable changes. The use of 0.0.0 when that doesn't exist as a tag is still potentially worrying.

0.0.0 is used as a sign of not finding tags in the language repo: https://github.com/googleapis/librarian/blob/1144f1c1baf392135d8c621caaecb7c3f4826ba9/internal/legacylibrarian/legacylibrarian/release_stage.go#L215

@JoeWang1127 JoeWang1127 requested a review from jskeet April 1, 2026 14:16
Comment thread librarian.yaml
- path: google/cloud/beyondcorp/clientconnectorservices/v1
- path: google/cloud/beyondcorp/clientgateways/v1
- name: biglake
version: 0.0.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I thought I'd looked at all of state.yaml, but I hadn't.

I've found the code in legacylibrarian now: https://github.com/googleapis/librarian/blob/main/internal/legacylibrarian/legacylibrarian/release_stage.go#L215C2-L215C32

All good.

@JoeWang1127 JoeWang1127 merged commit 22cda56 into googleapis:main Apr 1, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants