docs(storage): Update EnableParallelUpload documentation in writer.go#14328
Merged
cpriti-os merged 8 commits intogoogleapis:mainfrom Apr 2, 2026
Merged
docs(storage): Update EnableParallelUpload documentation in writer.go#14328cpriti-os merged 8 commits intogoogleapis:mainfrom
EnableParallelUpload documentation in writer.go#14328cpriti-os merged 8 commits intogoogleapis:mainfrom
Conversation
Added documentation for `EnableParallelUpload` in `storage/writer.go` to explicitly mention billing considerations (Class A ops), required IAM permissions (`storage.objects.delete`), warning on failed uploads leaving resources, and stating it's not a one size fits all solution, matching the content present in the Java library's `ParallelCompositeUploadBlobWriteSessionConfig` class description. Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
Added documentation for `EnableParallelUpload` in `storage/writer.go` to explicitly mention billing considerations (Class A ops), required IAM permissions (`storage.objects.delete`), warning on failed uploads leaving resources, and stating it's not a one size fits all solution, matching the content present in the Java library's `ParallelCompositeUploadBlobWriteSessionConfig` class description, but using generic terms for parallel uploads. Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
…61984208 docs: Update `EnableParallelUpload` documentation in `writer.go`
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request expands the documentation for parallel uploads in storage/writer.go, detailing cost implications, permission requirements, and performance considerations. The review feedback suggests using standard Google Cloud Storage terminology and improving the phrasing and punctuation of the performance warnings.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
- Simplify documentation for `Writer.EnableParallelUpload` in `storage/writer.go`. - Move the detailed considerations and trade-offs of parallel uploads to a new `# Parallel Uploads` section in `storage/doc.go`. - Link directly to the new section using `[Parallel Uploads]` in `writer.go`. - Add defensive returns in `grpc_metrics_test.go` to prevent nil pointer panics on test failure. Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
- Simplify documentation for `Writer.EnableParallelUpload` in `storage/writer.go`. - Move the detailed considerations and trade-offs of parallel uploads to a new `# Parallel Uploads` section in `storage/doc.go`. - Link directly to the new section using `[Parallel Uploads]` in `writer.go`. Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
…3523507583222314297 refactor: move EnableParallelUpload documentation to doc.go
krishnamd-jkp
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.