fix(internal/gapicgen): properly update modules that have no gapic changes#5945
Merged
codyoss merged 3 commits intogoogleapis:mainfrom Apr 26, 2022
Merged
fix(internal/gapicgen): properly update modules that have no gapic changes#5945codyoss merged 3 commits intogoogleapis:mainfrom
codyoss merged 3 commits intogoogleapis:mainfrom
Conversation
…anges Previously this was happening thanks to some logic the revolved around looking for UNKNOWN date in a generated gapic client. This logic was removed around a month ago and hense PRs that have genproto changes but no gapic changes have needed some manual updates. With this change the update process now parses out what kind of changes happened based on context aware commit messages. This means even if there we not chnages to the gapic client genproto will still get updated to the latest version if there were changes to message types.
quartzmo
reviewed
Apr 26, 2022
This was referenced Apr 26, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was happening thanks to some logic the revolved around
looking for UNKNOWN date in a generated gapic client. This logic was
removed around a month ago and hense PRs that have genproto changes
but no gapic changes have needed some manual updates. With this change
the update process now parses out what kind of changes happened based
on context aware commit messages. This means even if there we not chnages
to the gapic client genproto will still get updated to the latest version
if there were changes to message types.