feat: Replace string with typed unions for aspectRatio in image/video configs#821
feat: Replace string with typed unions for aspectRatio in image/video configs#821puretension wants to merge 3 commits intogoogleapis:mainfrom
Conversation
… configs Signed-off-by: puretension <rlrlfhtm5@gmail.com>
Signed-off-by: puretension <rlrlfhtm5@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @puretension, Thanks for your contribution to the SDK. We've noticed your forked repository currently has a merge conflict. Could you please resolve the conflict on your end so we can proceed with reviewing the PR? We appreciate your work. |
|
Hi @shmishra99, Thank you for the feedback! I've resolved the merge conflict on my end. The PR should now be ready for review. I really appreciate you taking the time to look at this contribution and have been looking forward to your feedback. |
Signed-off-by: puretension <rlrlfhtm5@gmail.com>
deb5900 to
a79ec8f
Compare
Summary
Improves type safety for
aspectRatioparameters across media generation APIs by replacing loosestringtypes with strongly-typed unions.Changes
ImageAspectRatioandVideoAspectRatiotype definitionsGenerateImagesConfig,EditImageConfig, andGenerateVideosConfiginterfaces🚀 Developer Experience Improvement
Benefits
Type Definitions