Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

Commit c44f70d

Browse files
Benjamin E. Coecallmehiphop
authored andcommitted
chore(deps): upgrade to newest version of @google-cloud/common (#657)
1 parent 92332dd commit c44f70d

6 files changed

Lines changed: 16 additions & 21 deletions

File tree

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"predocs-test": "npm run docs"
5050
},
5151
"dependencies": {
52-
"@google-cloud/common": "^0.31.0",
52+
"@google-cloud/common": "^0.32.0",
5353
"@google-cloud/paginator": "^0.2.0",
5454
"@google-cloud/promisify": "^0.4.0",
5555
"arrify": "^1.0.0",
@@ -83,6 +83,7 @@
8383
"@types/mime-types": "^2.1.0",
8484
"@types/mocha": "^5.2.3",
8585
"@types/nock": "^9.3.0",
86+
"@types/node": "11.12.4",
8687
"@types/node-fetch": "^2.1.3",
8788
"@types/once": "^1.4.0",
8889
"@types/proxyquire": "^1.3.28",
@@ -101,6 +102,7 @@
101102
"intelli-espower-loader": "^1.0.1",
102103
"jsdoc": "^3.5.4",
103104
"jsdoc-baseline": "git+https://github.com/hegemonic/jsdoc-baseline.git",
105+
"linkinator": "^1.1.2",
104106
"mocha": "^6.0.0",
105107
"nock": "^10.0.1",
106108
"node-fetch": "^2.2.0",
@@ -112,7 +114,6 @@
112114
"source-map-support": "^0.5.6",
113115
"tmp": "^0.1.0",
114116
"typescript": "~3.4.0",
115-
"uuid": "^3.1.0",
116-
"linkinator": "^1.1.2"
117+
"uuid": "^3.1.0"
117118
}
118119
}

src/bucket.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -847,8 +847,7 @@ class Bucket extends ServiceObject {
847847
baseUrl: '/b',
848848
id: name,
849849
createMethod: storage.createBucket.bind(storage),
850-
methods,
851-
requestModule: teenyRequest as typeof request,
850+
methods
852851
});
853852

854853
this.name = name;

src/channel.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ class Channel extends ServiceObject {
5555

5656
methods: {
5757
// Only need `request`.
58-
},
59-
requestModule: teenyRequest as typeof request,
58+
}
6059
};
6160

6261
super(config);

src/file.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import {promisifyAll} from '@google-cloud/promisify';
2020
import compressible = require('compressible');
2121
import concat = require('concat-stream');
2222
import * as crypto from 'crypto';
23-
import * as duplexify from 'duplexify';
2423
import * as extend from 'extend';
2524
import * as fs from 'fs';
2625
const hashStreamValidation = require('hash-stream-validation');
@@ -42,7 +41,8 @@ import {teenyRequest} from 'teeny-request';
4241
import {Storage} from './storage';
4342
import {Bucket} from './bucket';
4443
import {Acl} from './acl';
45-
import {ResponseBody, ApiError} from '@google-cloud/common/build/src/util';
44+
import {ResponseBody, ApiError, Duplexify, DuplexifyConstructor} from '@google-cloud/common/build/src/util';
45+
const duplexify: DuplexifyConstructor = require('duplexify');
4646
import {normalize} from './util';
4747

4848
export type GetExpirationDateResponse = [Date];
@@ -728,7 +728,6 @@ class File extends ServiceObject<File> {
728728
parent: bucket,
729729
baseUrl: '/o',
730730
id: encodeURIComponent(name),
731-
requestModule: teenyRequest as typeof r,
732731
methods,
733732
});
734733

@@ -2916,8 +2915,8 @@ class File extends ServiceObject<File> {
29162915
*
29172916
* @private
29182917
*/
2919-
startResumableUpload_(
2920-
dup: duplexify.Duplexify, options: CreateResumableUploadOptions): void {
2918+
startResumableUpload_(dup: Duplexify, options: CreateResumableUploadOptions):
2919+
void {
29212920
options = Object.assign(
29222921
{
29232922
metadata: {},
@@ -2966,8 +2965,8 @@ class File extends ServiceObject<File> {
29662965
*
29672966
* @private
29682967
*/
2969-
startSimpleUpload_(
2970-
dup: duplexify.Duplexify, options?: CreateResumableUploadOptions): void {
2968+
startSimpleUpload_(dup: Duplexify, options?: CreateResumableUploadOptions):
2969+
void {
29712970
options = Object.assign(
29722971
{
29732972
metadata: {},
@@ -3002,7 +3001,7 @@ class File extends ServiceObject<File> {
30023001
}
30033002

30043003
util.makeWritableStream(dup, {
3005-
makeAuthenticatedRequest: reqOpts => {
3004+
makeAuthenticatedRequest: (reqOpts: object) => {
30063005
this.request(reqOpts as DecorateRequestOptions, (err, body, resp) => {
30073006
if (err) {
30083007
dup.destroy(err);
@@ -3015,8 +3014,7 @@ class File extends ServiceObject<File> {
30153014
});
30163015
},
30173016
metadata: options.metadata,
3018-
request: reqOpts,
3019-
requestModule: teenyRequest as typeof r,
3017+
request: reqOpts
30203018
});
30213019
}
30223020
}

src/notification.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,7 @@ class Notification extends ServiceObject {
192192
baseUrl: '/notificationConfigs',
193193
id: id.toString(),
194194
createMethod: bucket.createNotification.bind(bucket),
195-
methods,
196-
requestModule: teenyRequest as typeof request,
195+
methods
197196
});
198197
}
199198

src/storage.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,7 @@ export class Storage extends Service {
287287
'https://www.googleapis.com/auth/cloud-platform',
288288
'https://www.googleapis.com/auth/devstorage.full_control',
289289
],
290-
packageJson: require('../../package.json'),
291-
requestModule: teenyRequest as typeof r,
290+
packageJson: require('../../package.json')
292291
};
293292

294293
super(config, options);

0 commit comments

Comments
 (0)