This repository was archived by the owner on Mar 3, 2026. It is now read-only.
chore(deps): upgrade to newest version of @google-cloud/common#657
Merged
callmehiphop merged 3 commits intomasterfrom Apr 3, 2019
Merged
chore(deps): upgrade to newest version of @google-cloud/common#657callmehiphop merged 3 commits intomasterfrom
callmehiphop merged 3 commits intomasterfrom
Conversation
googlebot
added
the
cla: yes
1 task
callmehiphop
approved these changes
Apr 3, 2019
Contributor
callmehiphop
left a comment
callmehiphop
left a comment
There was a problem hiding this comment.
LGTM, just needs a npm run fix
1 task
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 97.94% 97.92% -0.02%
==========================================
Files 9 9
Lines 874 869 -5
Branches 99 99
==========================================
- Hits 856 851 -5
Misses 9 9
Partials 9 9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the goal of getting master passing, pulls in
@types/node@11.12.4, as11.13.0is currently breaking the build.This PR brings in this breaking change which retires the configurable request object (unfortunately this didn't address the error on
master, because other dependencies brought in@types/node@11.13.0.