Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: Retry EPIPE Connection Errors + Attempt Retries in Resumable Upload Connection Errors#2040

Merged
ddelgrosso1 merged 5 commits intomainfrom
fix-epipe-resumable-error
Aug 12, 2022
Merged

fix: Retry EPIPE Connection Errors + Attempt Retries in Resumable Upload Connection Errors#2040
ddelgrosso1 merged 5 commits intomainfrom
fix-epipe-resumable-error

Conversation

@danielbankhead
Copy link
Copy Markdown
Contributor

@danielbankhead danielbankhead commented Aug 12, 2022

This PR does 2 things:

  • Adds support for retrying EPIPE errors
  • Fixes an issue where resumable uploads didn't attempt to retry connection-related errors at all

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Aug 12, 2022
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 12, 2022
@danielbankhead danielbankhead marked this pull request as ready for review August 12, 2022 19:29
@danielbankhead danielbankhead requested review from a team August 12, 2022 19:29
@danielbankhead danielbankhead changed the title fix: Retry Connection Errors fix: Retry EPIPE Connection Errors + Attempt Retries in Resumable Upload Connection Errors Aug 12, 2022
@ddelgrosso1 ddelgrosso1 merged commit ba35321 into main Aug 12, 2022
@ddelgrosso1 ddelgrosso1 deleted the fix-epipe-resumable-error branch August 12, 2022 19:50
shaffeeullah added a commit that referenced this pull request Aug 18, 2022
* test: add retries (#2039)

* refactor: remove unused `restart` private method (#2038)

Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com>

* fix: Retry `EPIPE` Connection Errors + Attempt Retries in Resumable Upload Connection Errors (#2040)

* feat: Add `epipe` as retryable error

* fix: capture and retry potential connection errors

* test: Add tests and remove logs

* test: set `retryOptions` by copy rather than reference

* fix: grammar

* chore(main): release 6.4.1 (#2036)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* test: add delay to bucket tests to reduce rate limiting errors (#2043)

* samples: storage.objects.insert precondition samples

* updated test

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
shaffeeullah added a commit that referenced this pull request Aug 18, 2022
…s.insert, storage.objects.patch, & storage.objects.delete samples (#2046)

* started copy sample

* samples: add preconditions to storage.objects.rewrite & storage.objects.delete samples

* linted files

* samples: storage.objects.insert precondition samples

* updated test

* samples: storage.objects.insert precondition samples (#2047)

* test: add retries (#2039)

* refactor: remove unused `restart` private method (#2038)

Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com>

* fix: Retry `EPIPE` Connection Errors + Attempt Retries in Resumable Upload Connection Errors (#2040)

* feat: Add `epipe` as retryable error

* fix: capture and retry potential connection errors

* test: Add tests and remove logs

* test: set `retryOptions` by copy rather than reference

* fix: grammar

* chore(main): release 6.4.1 (#2036)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* test: add delay to bucket tests to reduce rate limiting errors (#2043)

* samples: storage.objects.insert precondition samples

* updated test

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>

* Revert "samples: storage.objects.insert precondition samples (#2047)" (#2048)

This reverts commit ca1b4b7.

* storage.objects.patch sample updates

* destinationGenerationMatchPrecondition

* renamed variable

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants