Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

test: add delay to bucket tests to reduce rate limiting errors#2043

Merged
ddelgrosso1 merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:fix-flakey-tests
Aug 16, 2022
Merged

test: add delay to bucket tests to reduce rate limiting errors#2043
ddelgrosso1 merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:fix-flakey-tests

Conversation

@ddelgrosso1
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2042 🦕
Fixes #2030

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Aug 15, 2022
@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review August 15, 2022 20:36
@ddelgrosso1 ddelgrosso1 requested review from a team August 15, 2022 20:36
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 15, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 15, 2022
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2022
@ddelgrosso1 ddelgrosso1 merged commit e58ee0b into googleapis:main Aug 16, 2022
@ddelgrosso1 ddelgrosso1 deleted the fix-flakey-tests branch August 16, 2022 14:43
shaffeeullah added a commit that referenced this pull request Aug 18, 2022
* test: add retries (#2039)

* refactor: remove unused `restart` private method (#2038)

Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com>

* fix: Retry `EPIPE` Connection Errors + Attempt Retries in Resumable Upload Connection Errors (#2040)

* feat: Add `epipe` as retryable error

* fix: capture and retry potential connection errors

* test: Add tests and remove logs

* test: set `retryOptions` by copy rather than reference

* fix: grammar

* chore(main): release 6.4.1 (#2036)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* test: add delay to bucket tests to reduce rate limiting errors (#2043)

* samples: storage.objects.insert precondition samples

* updated test

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
shaffeeullah added a commit that referenced this pull request Aug 18, 2022
…s.insert, storage.objects.patch, & storage.objects.delete samples (#2046)

* started copy sample

* samples: add preconditions to storage.objects.rewrite & storage.objects.delete samples

* linted files

* samples: storage.objects.insert precondition samples

* updated test

* samples: storage.objects.insert precondition samples (#2047)

* test: add retries (#2039)

* refactor: remove unused `restart` private method (#2038)

Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com>

* fix: Retry `EPIPE` Connection Errors + Attempt Retries in Resumable Upload Connection Errors (#2040)

* feat: Add `epipe` as retryable error

* fix: capture and retry potential connection errors

* test: Add tests and remove logs

* test: set `retryOptions` by copy rather than reference

* fix: grammar

* chore(main): release 6.4.1 (#2036)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* test: add delay to bucket tests to reduce rate limiting errors (#2043)

* samples: storage.objects.insert precondition samples

* updated test

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>

* Revert "samples: storage.objects.insert precondition samples (#2047)" (#2048)

This reverts commit ca1b4b7.

* storage.objects.patch sample updates

* destinationGenerationMatchPrecondition

* renamed variable

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage acls buckets: should make files public failed storage acls buckets: should make a bucket private failed

3 participants