This repository was archived by the owner on Mar 3, 2026. It is now read-only.
fix: correct STORAGE_EMULATOR_HOST handling (#2069, #1314)#2070
Merged
ddelgrosso1 merged 3 commits intogoogleapis:mainfrom Oct 18, 2022
Merged
fix: correct STORAGE_EMULATOR_HOST handling (#2069, #1314)#2070ddelgrosso1 merged 3 commits intogoogleapis:mainfrom
ddelgrosso1 merged 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: s
danielbankhead
approved these changes
Oct 5, 2022
Contributor
danielbankhead
left a comment
danielbankhead
left a comment
There was a problem hiding this comment.
Looks good - one minor, optional suggestion.
We have a code freeze for the next few weeks - will merge this after 🙂
shaffeeullah
added
the
kokoro:force-run
Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
yoshi-kokoro
removed
the
kokoro:force-run
danielbankhead
approved these changes
Oct 5, 2022
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
ddelgrosso1
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ddelgrosso1
added
the
cla: yes
danielbankhead
added a commit
that referenced
this pull request
Oct 19, 2022
shaffeeullah
pushed a commit
that referenced
this pull request
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
credit to @jpambrun for identifying the fix
Test assertions needed to change slightly since they were asserting the
presence of functionality that doesn't actually work, specifically allowing
one to change the base url to not have
/storage/v1. The code fundamentallydoes not support this at all, and is full of places that are hard coded to
always include that path element. The code does support having a base path
before that however, and so that is what I updated the tests to check.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1314
Fixes #2069