This repository was archived by the owner on Mar 3, 2026. It is now read-only.
feat: add File#rename#1311
Merged
AVaksman merged 4 commits intogoogleapis:masterfrom Oct 20, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
========================================
Coverage 98.98% 98.99%
========================================
Files 14 14
Lines 11581 11693 +112
Branches 529 601 +72
========================================
+ Hits 11464 11576 +112
Misses 117 117
Continue to review full report at Codecov.
|
| * billed for the request. | ||
| */ | ||
| /** | ||
| * Rename this file |
Contributor
There was a problem hiding this comment.
We should explain probably what "move()" does, that this is not an atomic operation, and also that this is an alias for "move()".
stephenplusplus
approved these changes
Oct 15, 2020
JustinBeckwith
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1308