Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

feat: add File#rename#1311

Merged
AVaksman merged 4 commits intogoogleapis:masterfrom
AVaksman:rename
Oct 20, 2020
Merged

feat: add File#rename#1311
AVaksman merged 4 commits intogoogleapis:masterfrom
AVaksman:rename

Conversation

@AVaksman
Copy link
Copy Markdown
Contributor

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1308

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2020

Codecov Report

Merging #1311 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1311    +/-   ##
========================================
  Coverage   98.98%   98.99%            
========================================
  Files          14       14            
  Lines       11581    11693   +112     
  Branches      529      601    +72     
========================================
+ Hits        11464    11576   +112     
  Misses        117      117            
Impacted Files Coverage Δ
src/file.ts 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e826a52...0c3c46d. Read the comment docs.

Comment thread src/file.ts Outdated
* billed for the request.
*/
/**
* Rename this file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should explain probably what "move()" does, that this is not an atomic operation, and also that this is an alias for "move()".

@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Oct 15, 2020
@AVaksman AVaksman marked this pull request as ready for review October 15, 2020 19:35
@AVaksman AVaksman requested a review from a team October 15, 2020 19:35
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2020
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@AVaksman AVaksman merged commit c77eaa3 into googleapis:master Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Their should be a function to rename file

4 participants