Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

feat: public url of a file#1324

Merged
shaffeeullah merged 4 commits intomasterfrom
shaffeeullah/public_url
Oct 26, 2020
Merged

feat: public url of a file#1324
shaffeeullah merged 4 commits intomasterfrom
shaffeeullah/public_url

Conversation

@shaffeeullah
Copy link
Copy Markdown
Contributor

@shaffeeullah shaffeeullah commented Oct 22, 2020

Created a function publicUrl equivalent to this python function.

Fixes #931

@shaffeeullah shaffeeullah requested a review from a team October 22, 2020 18:54
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
@shaffeeullah shaffeeullah requested a review from frankyn October 22, 2020 18:56
Comment thread src/file.ts Outdated
@shaffeeullah shaffeeullah requested a review from frankyn October 22, 2020 20:22
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
@shaffeeullah shaffeeullah added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
Comment thread src/file.ts Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 26, 2020

Codecov Report

Merging #1324 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   98.99%   99.00%           
=======================================
  Files          14       14           
  Lines       11693    11712   +19     
  Branches      601      582   -19     
=======================================
+ Hits        11576    11595   +19     
  Misses        117      117           
Impacted Files Coverage Δ
src/file.ts 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aadec92...be76b67. Read the comment docs.

@shaffeeullah shaffeeullah merged commit 5ec256e into master Oct 26, 2020
shaffeeullah added a commit that referenced this pull request Oct 26, 2020
@shaffeeullah shaffeeullah deleted the shaffeeullah/public_url branch October 26, 2020 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for url-like prop/method on files uploaded to storage

4 participants