This repository was archived by the owner on Mar 3, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 396
feat: support OLM Prefix/Suffix #1847
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
97b734f
feat: support OLM Prefix/Suffix
shaffeeullah 625788e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] a5104a7
updated to camel case
shaffeeullah 8307ea0
Merge branch 'shaffeeullah/olmPrefixSuffix' of github.com:googleapis/…
shaffeeullah 771d190
fix merge
shaffeeullah dca475c
Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…
shaffeeullah 8e295a4
fixed compile error
shaffeeullah df18e4f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 96ac702
refactored tests
shaffeeullah 948aea3
Merge branch 'shaffeeullah/olmPrefixSuffix' of github.com:googleapis/…
shaffeeullah 4aecd01
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 7483dde
refactored tests
shaffeeullah ab0a8a1
Merge branch 'shaffeeullah/olmPrefixSuffix' of github.com:googleapis/…
shaffeeullah 55c1017
refactored tests
shaffeeullah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1332,7 +1332,11 @@ describe('storage', () => { | |
| await bucket.addLifecycleRule({ | ||
| action: 'delete', | ||
| condition: { | ||
| <<<<<<< HEAD | ||
| matchesPrefix: [TESTS_PREFIX] | ||
| ======= | ||
| matches_prefix: [TESTS_PREFIX], | ||
| >>>>>>> 625788e33cc329b771c024a4d225fc8b43ac8256 | ||
| }, | ||
| }); | ||
|
|
||
|
|
@@ -1341,9 +1345,9 @@ describe('storage', () => { | |
| (rule: LifecycleRule) => | ||
| typeof rule.action === 'object' && | ||
| rule.action.type === 'Delete' && | ||
| typeof rule.condition.matches_prefix === 'object' && | ||
| (rule.condition.matches_prefix as string[]).length === 1 && | ||
| (rule.condition.matches_prefix as string[])[0] === TESTS_PREFIX | ||
| typeof rule.condition.matchesPrefix === 'object' && | ||
| (rule.condition.matchesPrefix as string[]).length === 1 && | ||
| (rule.condition.matchesPrefix as string[])[0] === TESTS_PREFIX | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Optional: You can use |
||
| ) | ||
| ); | ||
| }); | ||
|
|
@@ -1352,7 +1356,7 @@ describe('storage', () => { | |
| await bucket.addLifecycleRule({ | ||
| action: 'delete', | ||
| condition: { | ||
| matches_suffix: [TESTS_PREFIX, 'test_suffix'], | ||
| matchesSuffix: [TESTS_PREFIX, "test_suffix"] | ||
| }, | ||
| }); | ||
|
|
||
|
|
@@ -1361,7 +1365,7 @@ describe('storage', () => { | |
| (rule: LifecycleRule) => | ||
| typeof rule.action === 'object' && | ||
| rule.action.type === 'Delete' && | ||
| (rule.condition.matches_suffix as string[]).length === 2 | ||
| (rule.condition.matchesSuffix as string[]).length === 2 | ||
| ) | ||
| ); | ||
| }); | ||
|
|
@@ -1448,13 +1452,11 @@ describe('storage', () => { | |
| }, | ||
| }); | ||
|
|
||
| await bucket.addLifecycleRule( | ||
| { | ||
| action: 'delete', | ||
| condition: { | ||
| matches_prefix: [TESTS_PREFIX], | ||
| matches_suffix: [TESTS_PREFIX], | ||
| }, | ||
| await bucket.addLifecycleRule({ | ||
| action: 'delete', | ||
| condition: { | ||
| matchesPrefix: [TESTS_PREFIX], | ||
| matchesSuffix: [TESTS_PREFIX] | ||
| }, | ||
| {append: true} | ||
| ); | ||
|
|
@@ -1466,8 +1468,8 @@ describe('storage', () => { | |
| rule.action.type === 'Delete' && | ||
| rule.condition.customTimeBefore === CUSTOM_TIME_BEFORE && | ||
| rule.condition.daysSinceCustomTime === 100 && | ||
| (rule.condition.matches_prefix as string[]).length === 1 && | ||
| (rule.condition.matches_suffix as string[]).length === 1 | ||
| (rule.condition.matchesPrefix as string[]).length === 1 && | ||
| (rule.condition.matchesSuffix as string[]).length === 1 | ||
| ) | ||
| ); | ||
| }); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.