Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

test: do not use a resumable upload for ACL file test#1896

Merged
shaffeeullah merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:acl-system-test
Apr 28, 2022
Merged

test: do not use a resumable upload for ACL file test#1896
shaffeeullah merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:acl-system-test

Conversation

@ddelgrosso1
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1890 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team April 28, 2022 16:43
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 28, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2022
@shaffeeullah shaffeeullah added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2022
@shaffeeullah shaffeeullah merged commit 3d86c7c into googleapis:main Apr 28, 2022
ddelgrosso1 added a commit to ddelgrosso1/nodejs-storage that referenced this pull request Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage uniform bucket-level access preserves bucket/file ACL over uniform bucket-level access on/off: should preserve file ACL failed

3 participants