This repository was archived by the owner on Mar 3, 2026. It is now read-only.
feat: add functionality for passing preconditions at the function level#1993
Merged
shaffeeullah merged 70 commits intomainfrom Aug 10, 2022
Merged
feat: add functionality for passing preconditions at the function level#1993shaffeeullah merged 70 commits intomainfrom
shaffeeullah merged 70 commits intomainfrom
Conversation
…feeullah/preconditionUpdates
…feeullah/preconditionUpdates
product-auto-label
Bot
added
size: l
shaffeeullah
added
do not merge
product-auto-label
Bot
added
the
api: storage
…feeullah/preconditionUpdates
…feeullah/preconditionUpdates
…feeullah/preconditionUpdates
shaffeeullah
added
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
shaffeeullah
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
danielbankhead
left a comment
danielbankhead
left a comment
There was a problem hiding this comment.
Looks good, just 2 things
| } | ||
|
|
||
| if (typeof err.code === 'string') { | ||
| const reason = (err.code as string).toLowerCase(); |
Contributor
There was a problem hiding this comment.
The cast here shouldn’t be necessary.
Contributor
Author
There was a problem hiding this comment.
without this line it throws errors: Property 'toLowerCase' does not exist on type 'never'.
frankyn
reviewed
Aug 5, 2022
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Two comments, IIUC you're extending existing options with PreconditionOptions for all operations.
…#2020) * tests: remove callback waterfall from make bucket private system test * cleaner implementation
…pis/nodejs-storage into shaffeeullah/preconditionUpdates
shaffeeullah
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…pis/nodejs-storage into shaffeeullah/preconditionUpdates
danielbankhead
approved these changes
Aug 8, 2022
Contributor
Author
|
@frankyn can you please take another look at this when you have a sec? |
frankyn
reviewed
Aug 10, 2022
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
I had one more question, otherwise LGTM.
|
|
||
| if (typeof reqOpts.maxRetries === 'number') { | ||
| options.retries = reqOpts.maxRetries; | ||
| options.noResponseRetries = reqOpts.maxRetries; |
Contributor
There was a problem hiding this comment.
naive question, shouldn't this value come from maxRetryValue instead?
Contributor
Author
There was a problem hiding this comment.
reqOpts.maxRetries overrides maxRetryValue. It's used in cases where we need to override the user (like forcing no retries because of idempotency)
frankyn
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to pass preconditions at the function level. Also includes a few fixes such as:
Internal ticket: b/239141167