Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

refactor: system tests should use await#2024

Merged
shaffeeullah merged 13 commits intomainfrom
shaffeeullah/refactorTests
Aug 10, 2022
Merged

refactor: system tests should use await#2024
shaffeeullah merged 13 commits intomainfrom
shaffeeullah/refactorTests

Conversation

@shaffeeullah
Copy link
Copy Markdown
Contributor

@shaffeeullah shaffeeullah commented Aug 9, 2022 •
edited
Loading

fixes #2019

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Aug 9, 2022
@shaffeeullah shaffeeullah added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 9, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2022
@shaffeeullah shaffeeullah marked this pull request as ready for review August 9, 2022 17:03
@shaffeeullah shaffeeullah requested review from a team August 9, 2022 17:03
@shaffeeullah shaffeeullah added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2022
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 9, 2022
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 9, 2022
@shaffeeullah shaffeeullah removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2022
@ddelgrosso1
Copy link
Copy Markdown
Contributor

ddelgrosso1 commented Aug 10, 2022

Thanks for taking this on. Looks much cleaner now!

@shaffeeullah shaffeeullah merged commit 020c0eb into main Aug 10, 2022
@shaffeeullah shaffeeullah deleted the shaffeeullah/refactorTests branch August 10, 2022 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor(tests): move away from callbacks in system tests

4 participants

@shaffeeullah @ddelgrosso1 @danielbankhead @yoshi-kokoro
⚡