Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

docs: new synthtool generated README#645

Merged
bcoe merged 5 commits intomasterfrom
new-readme
Mar 27, 2019
Merged

docs: new synthtool generated README#645
bcoe merged 5 commits intomasterfrom
new-readme

Conversation

@bcoe
Copy link
Copy Markdown

@bcoe bcoe commented Mar 26, 2019

refs: googleapis/google-cloud-node#2868 this PR regenerates our README using synthtool rather than node-repo-tools.

It seems to be most of the way there, one thing that does jump out at me is the description isn't nearly as fleshed out ... I wonder if this grew organically over time; any thoughts about how to auto-generate the README with up-to-date samples, while maintaining a more useful description?

@busunkim96 thanks for all your help on this!

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@bcoe bcoe requested review from JustinBeckwith and jkwlui March 26, 2019 20:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2019
Comment thread README.md
Comment thread README.md Outdated
> Node.js idiomatic client for [Cloud Storage][product-docs].
Cloud Storage Client Library for Node.js

[Cloud Storage](https://cloud.google.com/storage/docs) allows world-wide storage and retrieval of any amount of data at any time. You can use Google Cloud Storage for a range of scenarios including serving website content, storing data for archival and disaster recovery, or distributing large data objects to users via direct download.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it would be really nice to hang onto this, I think. Not sure if putting the long description in the metadata or embedding it in a README.md.tpl file is the right path.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose the late-game addition of readme-partials.yml, with a section introduction. This would give us the flexibility to gradually hand-write some portions of the API documentation, which I think we're going to inevitably want for our libraries.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it looks like it's copied from https://cloud.google.com/storage/docs/ verbatim.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcoe I really think this is a great idea. We had a few issues come up in the past asking for this, even with nodejs-repo-tools.

Comment thread README.md Outdated
@callmehiphop
Copy link
Copy Markdown
Contributor

Something that has always bugged me about the README's is that the link for the client API docs is not really in a convenient spot. IMO it should be available right at the start and I shouldn't need to scan the document for it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2019

Codecov Report

Merging #645 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           9        9           
  Lines         874      874           
  Branches       99       99           
=======================================
  Hits          856      856           
  Misses          9        9           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9916cc5...d4b5c42. Read the comment docs.

Copy link
Copy Markdown
Author

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I think this is ready for final review; it hinges on this:

googleapis/synthtool#208

landing.

Comment thread .readme-partials.yaml Outdated
Cloud Storage for a range of scenarios including serving website content,
storing data for archival and disaster recovery, or distributing large data
objects to users via direct download.
quickstart_footer:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinBeckwith @callmehiphop it's now possible to customize the README output with .readme-partials.yaml. Right now the supported keys are introduction (for a handwritten library intro), and quickstart_footer, allowing us to provide some shim code that actually makes the quickstart functional.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #647 landing, can we drop this?

@bcoe bcoe requested a review from callmehiphop March 27, 2019 01:32
@bcoe bcoe merged commit 53e290e into master Mar 27, 2019
@bcoe bcoe deleted the new-readme branch March 27, 2019 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants