Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

refactor: modernize sample tests#199

Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:chai
Dec 18, 2018
Merged

refactor: modernize sample tests#199
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:chai

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented Dec 15, 2018

So there's a lot going on here.

  1. Dumping sinon and proxyquire in one set of sample tests in favor of just running the sample code
  2. Using chai for assert.match instead of .includes, as it shows both bits of text when a test fails
  3. Moving the system tests for automl into the upper level system test directory.
  4. Explicitly skipping the automl tests. They were previously never getting run because they were in a subdirectory. They need to be addressed in a follow up PR.
  5. Using us-central as a default region in a few places
  6. Swapping nodejs-repo-tools for execa

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2018
@JustinBeckwith JustinBeckwith merged commit 6e48e8e into googleapis:master Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants