docs(readme): Update defaults format to use booleans (true/false)#408
Merged
bcoe merged 2 commits intogoogleapis:mainfrom Jan 12, 2022
jcornaz:patch-1
Merged
docs(readme): Update defaults format to use booleans (true/false)#408bcoe merged 2 commits intogoogleapis:mainfrom jcornaz:patch-1
true/false)#408bcoe merged 2 commits intogoogleapis:mainfrom
jcornaz:patch-1
Conversation
bcoe
approved these changes
Dec 31, 2021
|
@jcornaz thank you 👏 I think you just need to sign the CLA before I can merge. |
Contributor
Author
Done. |
|
thanks for the contribution @jcornaz |
goatwu1993
pushed a commit
to goatwu1993/release-please-action
that referenced
this pull request
Jul 19, 2022
…googleapis#408) Co-authored-by: Benjamin E. Coe <bencoe@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #398 the input booleans no longer accept
YesorNo, but onlytrueorfalse.Some defaults mentionned in the readme are using the old format (Example: "default:
No"), which is now outdated and misleading.This PR updates the readme to use only boolean notation (
true/false) when describing defaults.