fix: default labels should be undefined#566
Merged
Conversation
SurferJeffAtGoogle
approved these changes
Aug 15, 2022
This was referenced Aug 15, 2022
Merged
Closed
This was referenced Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes the build issue where the release-PR labels are defaulting to
[]when it should default toundefined.getMultilineInput()defaults to returning[]when the config entry is not set.This is causing the dogfood run of this action to fail: https://github.com/google-github-actions/release-please-action/runs/7845000323?check_suite_focus=true
This bug was introduced in #474 but is unreleased.
@actions/coredoes not provide any guidance on how to test default inputs.