Skip to content

fix: stop providing default values in action.yml #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 3 commits into from
Aug 22, 2022
Merged

fix: stop providing default values in action.yml #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049bbf5
fix: stop providing default values in action.yml
chingor13 Aug 16, 2022
689e799
fix: optional boolean parsing
chingor13 Aug 16, 2022
d5cbb2e
Merge branch 'main' into stop-default
chingor13 Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,15 @@ inputs:
monorepo-tags:
description: 'add prefix to tags and branches, allowing multiple libraries to be released from the same repository'
required: false
default: false
pull-request-title-pattern:
description: 'add title pattern to make release PR, defaults to using "chore${scope}: release${component} ${version}"'
required: false
default: ''
draft:
description: 'mark release as a draft'
required: false
default: false
draft-pull-request:
description: 'mark pull request as a draft'
required: false
default: false
changelog-notes-type:
description: "Strategy for building the changelog contents(see https://github.com/googleapis/release-please/blob/main/docs/customizing.md#changelog-types). Default `default`. Called `changelog-type` in release-please documentation."
required: false
Expand All @@ -112,18 +108,15 @@ inputs:
skip-github-release:
description: 'Skip creating GitHub Releases. Default `false`'
required: false
default: false
prerelease:
description: 'If set, create releases that are pre-major or pre-release version marked as pre-release on Github. Defaults `false`'
required: false
default: false
component:
description: 'name of the component used for branch naming and release tagging, defaults to a normalized version based on the package name'
required: false
include-v-in-tag:
description: 'include "v" in tag versions. Default `true`'
required: false
default: true
tag-separator:
description: 'configures separator character used in release tag'
required: false
Expand All @@ -139,11 +132,9 @@ inputs:
always-link-local:
description: 'when using the `node-workspace` plugin, setting to false will only bump your local dependencies within the SemVer range (see the manifest releaser docs)[https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md) . Default `true`.'
required: false
default: true
separate-pull-requests:
description: 'create separate pull requests for each package instead of a single manifest release pull request (see the manifest releaser docs https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md). Default `false`.'
required: false
default: false
plugins:
description: 'see https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#plugins'
required: false
Expand All @@ -156,11 +147,9 @@ inputs:
skip-labeling:
description: 'if set, labels will not be applied to pull requests. Default `false`.'
required: false
default: false
sequential-calls:
description: 'issue GitHub API requests sequentially rather than concurrently (see the manifest releaser docs https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md). Default `false`'
required: false
default: false
group-pull-request-title-pattern:
description: 'sets the manifest pull request title for when releasing multiple packages grouped together in the one pull request'
required: false
Expand Down
44 changes: 29 additions & 15 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const signoff = core.getInput('signoff') || undefined

function getGitHubInput () {
return {
fork: core.getBooleanInput('fork'),
fork: getOptionalBooleanInput('fork'),
defaultBranch: core.getInput('default-branch') || undefined,
repoUrl: core.getInput('repo-url') || process.env.GITHUB_REPOSITORY,
apiUrl: core.getInput('github-api-url') || GITHUB_API_URL,
Expand All @@ -23,6 +23,20 @@ function getGitHubInput () {
}
}

function getOptionalBooleanInput (name) {
if (core.getInput(name) === '') {
return undefined
}
return core.getBooleanInput(name)
}

function getOptionalMultilineInput (name) {
if (core.getInput(name) === '') {
return undefined
}
return core.getMultilineInput(name)
}

function getManifestInput () {
return {
configFile: core.getInput('config-file') || CONFIG_FILE,
Expand Down Expand Up @@ -106,9 +120,9 @@ function getGitHubInstance () {

async function manifestInstance (github) {
const { fork } = getGitHubInput()
const bumpMinorPreMajor = core.getBooleanInput('bump-minor-pre-major')
const bumpPatchForMinorPreMajor = core.getBooleanInput('bump-patch-for-minor-pre-major')
const monorepoTags = core.getBooleanInput('monorepo-tags')
const bumpMinorPreMajor = getOptionalBooleanInput('bump-minor-pre-major')
const bumpPatchForMinorPreMajor = getOptionalBooleanInput('bump-patch-for-minor-pre-major')
const monorepoTags = getOptionalBooleanInput('monorepo-tags')
const packageName = core.getInput('package-name') || undefined
const path = core.getInput('path') || undefined
const releaseType = core.getInput('release-type', { required: true })
Expand All @@ -119,26 +133,26 @@ async function manifestInstance (github) {
const versionFile = core.getInput('version-file') || undefined
const extraFiles = core.getMultilineInput('extra-files') || undefined
const pullRequestTitlePattern = core.getInput('pull-request-title-pattern') || undefined
const draft = core.getBooleanInput('draft')
const draftPullRequest = core.getBooleanInput('draft-pull-request')
const draft = getOptionalBooleanInput('draft')
const draftPullRequest = getOptionalBooleanInput('draft-pull-request')
const changelogType = core.getInput('changelog-notes-type') || undefined
const versioning = core.getInput('versioning-strategy') || undefined
const releaseAs = core.getInput('release-as') || undefined
const skipGithubRelease = core.getBooleanInput('skip-github-release')
const prerelease = core.getBooleanInput('prerelease')
const skipGithubRelease = getOptionalBooleanInput('skip-github-release')
const prerelease = getOptionalBooleanInput('prerelease')
const component = core.getInput('component') || undefined
const includeVInTag = core.getBooleanInput('include-v-in-tag')
const includeVInTag = getOptionalBooleanInput('include-v-in-tag')
const tagSeparator = core.getInput('tag-separator') || undefined
const snapshotLabels = core.getInput('snapshot-labels') ? core.getMultilineInput('snapshot-labels') : undefined
const snapshotLabels = getOptionalMultilineInput('snapshot-labels')
const bootstrapSha = core.getInput('bootstrap-sha') || undefined
const lastReleaseSha = core.getInput('last-release-sha') || undefined
const alwaysLinkLocal = core.getBooleanInput('always-link-local')
const separatePullRequests = core.getBooleanInput('separate-pull-requests')
const alwaysLinkLocal = getOptionalBooleanInput('always-link-local')
const separatePullRequests = getOptionalBooleanInput('separate-pull-requests')
const plugins = core.getMultilineInput('plugins') || undefined
const labels = core.getInput('labels') ? core.getMultilineInput('labels') : undefined
const releaseLabels = core.getInput('release-labels') ? core.getMultilineInput('release-labels') : undefined
const skipLabeling = core.getBooleanInput('skip-labeling')
const sequentialCalls = core.getBooleanInput('sequential-calls')
const releaseLabels = getOptionalMultilineInput('release-labels')
const skipLabeling = getOptionalBooleanInput('skip-labeling')
const sequentialCalls = getOptionalBooleanInput('sequential-calls')
const groupPullRequestTitlePattern = core.getInput('group-pull-request-title-pattern') || undefined
const releaseSearchDepth = core.getInput('release-search-depth') || undefined
const commitSearchDepth = core.getInput('commit-search-depth') || undefined
Expand Down
⚡