-
Notifications
You must be signed in to change notification settings - Fork 543
Do not change modes of existing files #1027
Copy link
Copy link
Closed
Labels
help wantedWe'd love to have community involvement on this issue.We'd love to have community involvement on this issue.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Metadata
Metadata
Assignees
Labels
help wantedWe'd love to have community involvement on this issue.We'd love to have community involvement on this issue.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
release-please appears to not only create files with, but also change modes of existing files to mode 644 unconditionally.
This can actually cause breakage -- for example for python projects,
setup.py,projectname/__init__.pyandversion.pyfound in the tree can be intentionally executable, and making them 644 will break that.It's fine to create new ones with 644 (although honoring umask would be appropriate as a general practice, haven't checked if it's honored/not), but I suggest making it so that existing files' modes are not changed.