Skip to content

fix(go-yoshi): dynamically load list of ignored submodules for google-cloud-go#1291

Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom
yoshi-go-main
Feb 14, 2022
Merged

fix(go-yoshi): dynamically load list of ignored submodules for google-cloud-go#1291
gcf-merge-on-green[bot] merged 2 commits intomainfrom
yoshi-go-main

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Feb 9, 2022

The root module was always intended to only include non-submodule components. We now dynamically load the list by finding the go.mod files in the repository.

This fixes the root component release PRs to look like: googleapis/google-cloud-go#5498

@chingor13 chingor13 requested review from a team February 9, 2022 22:49
@chingor13
Copy link
Copy Markdown
Contributor Author

cc @codyoss

@chingor13 chingor13 requested a review from bcoe February 9, 2022 22:55
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@chingor13 chingor13 added this to the Next milestone Feb 10, 2022
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 14, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 36f6ad9 into main Feb 14, 2022
@gcf-merge-on-green gcf-merge-on-green Bot deleted the yoshi-go-main branch February 14, 2022 23:30
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 14, 2022
gcf-merge-on-green Bot pushed a commit that referenced this pull request Feb 16, 2022
🤖 I have created a release *beep* *boop*
---


### [13.4.10](v13.4.9...v13.4.10) (2022-02-16)


### Bug Fixes

* **go-yoshi:** dynamically load list of ignored submodules for google-cloud-go ([#1291](#1291)) ([36f6ad9](36f6ad9))
* manifest release can handle componentless entry ([#1300](#1300)) ([6b58573](6b58573))
* return uploadUrl and body when creating release ([#1298](#1298)) ([5d767c5](5d767c5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants