Skip to content

fix: return uploadUrl and body when creating release#1298

Merged
bcoe merged 2 commits intomainfrom
release-outputs
Feb 14, 2022
Merged

fix: return uploadUrl and body when creating release#1298
bcoe merged 2 commits intomainfrom
release-outputs

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Feb 14, 2022

release-please now returns an addition uploadUrl field when creating a release. Additionally, we fix it to look in all the body fields (body_text, body, and body_html) to attempt to return the release notes. This value has been returned as notes since v13 and will continue to do so.

Fixes #1286

@chingor13 chingor13 changed the title test: failing test for returning uploadUrl and body when creating rel… fix: return uploadUrl and body when creating release Feb 14, 2022
@chingor13 chingor13 marked this pull request as ready for review February 14, 2022 22:28
@chingor13 chingor13 requested review from a team and bcoe February 14, 2022 22:28
@bcoe bcoe merged commit 5d767c5 into main Feb 14, 2022
@bcoe bcoe deleted the release-outputs branch February 14, 2022 23:02
gcf-merge-on-green Bot pushed a commit that referenced this pull request Feb 16, 2022
🤖 I have created a release *beep* *boop*
---


### [13.4.10](v13.4.9...v13.4.10) (2022-02-16)


### Bug Fixes

* **go-yoshi:** dynamically load list of ignored submodules for google-cloud-go ([#1291](#1291)) ([36f6ad9](36f6ad9))
* manifest release can handle componentless entry ([#1300](#1300)) ([6b58573](6b58573))
* return uploadUrl and body when creating release ([#1298](#1298)) ([5d767c5](5d767c5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing a bunch of "outputs" that were used by release-please-action

2 participants