Skip to content

fix: return uploadUrl and body when creating release #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcoe merged 2 commits into from
Feb 14, 2022
Merged

fix: return uploadUrl and body when creating release #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4b02b0
test: failing test for returning uploadUrl and body when creating rel…
chingor13 Feb 14, 2022
a38bd67
fix: return uploadUrl and body when creating release
chingor13 Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ export interface GitHubRelease {
notes?: string;
url: string;
draft?: boolean;
uploadUrl?: string;
}

export interface GitHubTag {
Expand Down Expand Up @@ -1246,9 +1247,14 @@ export class GitHub {
name: resp.data.name || undefined,
tagName: resp.data.tag_name,
sha: resp.data.target_commitish,
notes: resp.data.body_text,
notes:
resp.data.body_text ||
resp.data.body ||
resp.data.body_html ||
undefined,
url: resp.data.html_url,
draft: resp.data.draft,
uploadUrl: resp.data.upload_url,
};
},
e => {
Expand Down
5 changes: 5 additions & 0 deletions test/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ describe('GitHub', () => {
upload_url:
'https://uploads.github.com/repos/fake/fake/releases/1/assets{?name,label}',
target_commitish: 'abc123',
body: 'Some release notes response.',
});
const release = await github.createRelease({
tag: new TagName(Version.parse('1.2.3')),
Expand All @@ -625,6 +626,10 @@ describe('GitHub', () => {
expect(release.tagName).to.eql('v1.2.3');
expect(release.sha).to.eql('abc123');
expect(release.draft).to.be.false;
expect(release.uploadUrl).to.eql(
'https://uploads.github.com/repos/fake/fake/releases/1/assets{?name,label}'
);
expect(release.notes).to.eql('Some release notes response.');
});

it('should raise a DuplicateReleaseError if already_exists', async () => {
Expand Down
⚡