fix: allow brackets in custom pull request title#1445
Merged
gcf-merge-on-green[bot] merged 5 commits intomainfrom May 24, 2022
Merged
fix: allow brackets in custom pull request title#1445gcf-merge-on-green[bot] merged 5 commits intomainfrom
gcf-merge-on-green[bot] merged 5 commits intomainfrom
Conversation
chingor13
force-pushed
the
complex-title-pattern
branch
from
f13d14f to
508a475
Compare
chingor13
force-pushed
the
complex-title-pattern
branch
from
508a475 to
67fa2ad
Compare
chingor13
changed the title
product-auto-label
Bot
added
size: m
chingor13
force-pushed
the
complex-title-pattern
branch
from
0712856 to
6bc7524
Compare
bcoe
reviewed
May 24, 2022
| return new RegExp( | ||
| `^${(pullRequestTitlePattern || DEFAULT_PR_TITLE_PATTERN) | ||
| .replace('${scope}', '(\\((?<branch>[\\w-.]+)\\))?') | ||
| .replace('[', '\\[') |
There was a problem hiding this comment.
perhaps worth pulling in the dep escape-string-regexp, we already rely on it as a deep dep, keep the same tests.
Contributor
Author
There was a problem hiding this comment.
Note: v5 of that library is the only one with types and our current dependencies use v1 and v4. Additionally, I was having issues with ESM using that library. I added a TODO to handle all regex characters.
Contributor
Author
There was a problem hiding this comment.
Note: v5 of that library is the only one with types and our current dependencies use v1 and v4. Additionally, I was having issues with ESM using that library. I added a TODO to handle all regex characters.
bcoe
approved these changes
May 24, 2022
chingor13
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1444