Skip to content

fix: pull request title component can include '/' #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 2 commits into from
Jun 30, 2022
Merged

fix: pull request title component can include '/' #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f1acf3
test: failing test for parsing pull request title with slash in compo…
chingor13 Jun 30, 2022
5abc766
fix: pull request title component can include '/'
chingor13 Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/util/pull-request-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function generateMatchPattern(pullRequestTitlePattern?: string): RegExp {
.replace('[', '\\[') // TODO: handle all regex escaping
.replace(']', '\\]')
.replace('${scope}', '(\\((?<branch>[\\w-./]+)\\))?')
.replace('${component}', ' ?(?<component>[\\w-.]*)?')
.replace('${component}', ' ?(?<component>[\\w-./]*)?')
.replace('${version}', 'v?(?<version>[0-9].*)')
.replace('${branch}', '(?<branch>[\\w-./]+)?')}$`
);
Expand Down
13 changes: 11 additions & 2 deletions test/util/pull-request-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,15 @@ describe('PullRequestTitle', () => {
expect(pullRequestTitle?.getVersion()?.toString()).to.eql('1.2.3');
});

it('parses a target branch and component with a slash', () => {
const name = 'chore(main): release some/title-test 0.0.1';
const pullRequestTitle = PullRequestTitle.parse(name);
expect(pullRequestTitle).to.not.be.undefined;
expect(pullRequestTitle?.getTargetBranch()).to.eql('main');
expect(pullRequestTitle?.getComponent()).to.eql('some/title-test');
expect(pullRequestTitle?.getVersion()?.toString()).to.eql('0.0.1');
});

it('fails to parse', () => {
const pullRequestTitle = PullRequestTitle.parse('release-foo');
expect(pullRequestTitle).to.be.undefined;
Expand Down Expand Up @@ -124,7 +133,7 @@ describe('PullRequestTitle', () => {
it('return matchPattern with default Pattern', () => {
const matchPattern = generateMatchPattern();
expect(matchPattern).to.eql(
/^chore(\((?<branch>[\w-./]+)\))?: release ?(?<component>[\w-.]*)? v?(?<version>[0-9].*)$/
/^chore(\((?<branch>[\w-./]+)\))?: release ?(?<component>[\w-./]*)? v?(?<version>[0-9].*)$/
);
});
});
Expand Down Expand Up @@ -278,7 +287,7 @@ describe('PullRequestTitle with custom pullRequestTitlePattern', () => {
'chore${scope}: 🔖 release${component} ${version}'
);
expect(matchPattern).to.eql(
/^chore(\((?<branch>[\w-./]+)\))?: 🔖 release ?(?<component>[\w-.]*)? v?(?<version>[0-9].*)$/
/^chore(\((?<branch>[\w-./]+)\))?: 🔖 release ?(?<component>[\w-./]*)? v?(?<version>[0-9].*)$/
);
});

Expand Down
⚡